[DOC][Minor]Specify the common sources available for collecting #6641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -47,6 +47,10 @@ | |||
| # instance master and applications. MetricsServlet may not be configured by self. | |||
| # | |||
|
|
|||
| ## List of available common sources and their properties. | |||
|
|
|||
| # org.apache.spark.metrics.source.JvmSource | |||
Member
There was a problem hiding this comment.
This isn't the only Source, and this doesn't document anything about it. What's the value?
Member
Author
There was a problem hiding this comment.
It's the only Common Source users can add additionally, all the spark internal source are added automatically.
No value for this one, just as org.apache.spark.metrics.sink.JmxSink.
Member
|
OK, if so then this seems at least harmless and has some value. LGTM. |
Member
|
OK to test |
Member
|
Jenkins, test this please |
|
Test build #34211 has finished for PR 6641 at commit
|
jeanlyn
pushed a commit
to jeanlyn/spark
that referenced
this pull request
Jun 12, 2015
I was wondering what else common sources available until search the source code. Maybe better to make this clear. Author: Yijie Shen <henry.yijieshen@gmail.com> Closes apache#6641 from yijieshen/patch-1 and squashes the following commits: b5b99b4 [Yijie Shen] Make it clear that JvmSource is the only available additional source currently f23140c [Yijie Shen] [DOC][Minor]Specify the common sources available for collecting
nemccarthy
pushed a commit
to nemccarthy/spark
that referenced
this pull request
Jun 19, 2015
I was wondering what else common sources available until search the source code. Maybe better to make this clear. Author: Yijie Shen <henry.yijieshen@gmail.com> Closes apache#6641 from yijieshen/patch-1 and squashes the following commits: b5b99b4 [Yijie Shen] Make it clear that JvmSource is the only available additional source currently f23140c [Yijie Shen] [DOC][Minor]Specify the common sources available for collecting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was wondering what else common sources available until search the source code. Maybe better to make this clear.